https://bugzilla.redhat.com/show_bug.cgi?id=1060817 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- == REVIEW == Three minor issues: * You've got a typo in the rm of the bundled xmlrpc library. It should be: rm -rf src/xmlrpcpp * Without the xmlrpcpp bits, there is no LGPL code I can see. Drop that from the License: tag. "GPLv3+ and GPLv2+" is correct. * BuildRequires: autoconf automake Don't see those being used. I'm guessing you added these at some point when you were having to regen the configure file. Probably should be removed. Fix these before doing the Fedora builds, please. :) Otherwise APPROVED Good: - rpmlint checks return: fllog.src: W: spelling-error %description -l en_US polymorphism -> polymorphic, polymorphous fllog.x86_64: W: spelling-error %description -l en_US polymorphism -> polymorphic, polymorphous fllog.x86_64: W: no-manual-page-for-binary fllog 3 packages and 0 specfiles checked; 0 errors, 3 warnings. All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+ and GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (7cac198e0e9def5853a6b3df1ad1968752a90f0d2d3477e071567fdde4c436d3) - package compiles on f22 (x86_64) - no missing BR - no unnecessary BR (except as noted above) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop okay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review