[Bug 1224966] Review Request: perl-MouseX-StrictConstructor - Make your object constructors blow up on unknown attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1224966

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Tip: Instead of commenting it out, you could just delete the line in your
patch.

Tip: If you want to cut the dep list, you could also remove the
auto_set_repository() call and get rid of Module::Install::Repository.  Since
we don't ship META.* files, it's rather useless.

I can't see `strict' being used anywhere.  I suppose you can safely drop it. 
Although it won't really change much.

Add a version constraint to the autodetected `Mouse' dependency and filter out
the unversioned one.

I don't consider any of this a review blocker.  Approving.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]