[Bug 1223461] Review Request: python-glusterfs-api - python bindings of libgfapi library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1223461



--- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:
+ package builds find in mock F23 x86_64

+ rpmlint on all generated rpms gave output
python-glusterfs-api.noarch: W: spelling-error Summary(en_US) libgfapi ->
libation
python-glusterfs-api.noarch: W: spelling-error %description -l en_US
extensibility -> sensibility, extensible
python-glusterfs-api.noarch: W: spelling-error %description -l en_US libgfapi
-> libation
python-glusterfs-api.src: W: spelling-error Summary(en_US) libgfapi -> libation
python-glusterfs-api.src: W: spelling-error %description -l en_US extensibility
-> sensibility, extensible
python-glusterfs-api.src: W: spelling-error %description -l en_US libgfapi ->
libation
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
==> Ok

- License tag "GPLv2 or LGPLv3+" is wrong and should be "ASL 2.0"

+ Source packaged is verified with upstream source as (sha256sum)
tarball in srpm:
357ccd2a985dfc44849928c6981a19129cce899a77f35bef9034680055ffa49c
upstream tarball:
357ccd2a985dfc44849928c6981a19129cce899a77f35bef9034680055ffa49c

+ follows python packaging

Issues:
1) I still see 
=====================================
Diff spec file in url and in SRPM
---------------------------------
--- /home/parag/1223461-python-glusterfs-api/srpm/python-glusterfs-api.spec    
2015-05-25 13:28:15.399281488 +0530
+++
/home/parag/1223461-python-glusterfs-api/srpm-unpacked/python-glusterfs-api.spec
   2015-05-25 13:18:36.000000000 +0530
@@ -84,2 +84,3 @@
 - Introducing spec file.

+
======================================
package the same spec file in srpm

2) Directories without known owners: /usr/lib/python2.7/site-packages/gluster
=> Fix this by changing in %files
%{python2_sitelib}/gluster/gfapi/
to
%{python2_sitelib}/gluster

3) when I did mock build I see package is not installing files which are
actually getting %exclude so you can remove following lines from spec
======================================
# unit and functional test files are part of source, however we are not
packaging it, so adding them in
# exclude.
%exclude %{buildroot}/test/
%exclude %{buildroot}/functional_tests.sh
%exclude %{buildroot}/test-requirements.txt
%exclude %{buildroot}/tox.ini
%exclude %{buildroot}/unittests.sh
======================================

4) I checked all 3 .py files and found each source file having "ASL 2.0"
license header and also source tarball contains now "LICENSE" file.
=> Change license tag to "ASL 2.0"
in %files change
%license COPYING-GPLV2 COPYING-LGPLV3
to
%license LICENSE

5) When you submit update, you need to increase release tag to 2 and add new
changelog entry for today's date and log as "Fix issues for this package
review"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]