https://bugzilla.redhat.com/show_bug.cgi?id=1224385 --- Comment #3 from David Tardon <dtardon@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or generated". 84 files have unknown license. I assume that the LGPLv2+ sources are not used? [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 11499520 bytes in /usr/share percolator-2.09.0-1.fc20.x86_64.rpm:11499520 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines Rpmlint ------- Checking: percolator-2.09.0-1.fc20.x86_64.rpm percolator-2.09.0-1.fc20.src.rpm percolator.x86_64: W: spelling-error Summary(en_US) postprocessing -> post processing, post-processing, teleprocessing percolator.x86_64: W: spelling-error Summary(en_US) proteomics -> Proterozoic percolator.x86_64: W: spelling-error %description -l en_US spectrometry -> spectrometer, spectroscopy, spectroscope percolator.x86_64: W: spelling-error %description -l en_US peptide -> pep tide, pep-tide, peptic percolator.x86_64: E: description-line-too-long C The first step in analyzing an mass spectrometry assay is to match the harvested spectra percolator.x86_64: E: description-line-too-long C against a target database using database search engines such as Sequest and Mascot, percolator.x86_64: E: description-line-too-long C and calculates accurate statistics such as q-value (FDR) and posterior error probabilities. percolator.x86_64: E: script-without-shebang /usr/share/licenses/percolator/license.txt percolator.x86_64: W: spurious-executable-perm /usr/share/doc/percolator/ReadMe.txt percolator.x86_64: W: no-manual-page-for-binary tandem2pin percolator.x86_64: W: no-manual-page-for-binary msgf2pin percolator.x86_64: W: no-manual-page-for-binary percolator percolator.x86_64: W: no-manual-page-for-binary elude percolator.x86_64: W: no-manual-page-for-binary qvality percolator.x86_64: W: no-manual-page-for-binary sqt2pin percolator.src: W: spelling-error Summary(en_US) postprocessing -> post processing, post-processing, teleprocessing percolator.src: W: spelling-error Summary(en_US) proteomics -> Proterozoic percolator.src: W: spelling-error %description -l en_US spectrometry -> spectrometer, spectroscopy, spectroscope percolator.src: W: spelling-error %description -l en_US peptide -> pep tide, pep-tide, peptic percolator.src: E: description-line-too-long C The first step in analyzing an mass spectrometry assay is to match the harvested spectra percolator.src: E: description-line-too-long C against a target database using database search engines such as Sequest and Mascot, percolator.src: E: description-line-too-long C and calculates accurate statistics such as q-value (FDR) and posterior error probabilities. 2 packages and 0 specfiles checked; 7 errors, 15 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review