https://bugzilla.redhat.com/show_bug.cgi?id=1224420 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok c63fd69023a52adf369a371d22cc2ece iio-sensor-proxy-1.0.tar.xz 2. %build SHOULD be verbose, please add %configure --disable-silent-rules or use %make_build V=1 macros: ok scriptlets ok 3. license: NOT ok, most(many?) sources are GPLv2 only, so MUST use: License: GPLv2 builds/installs/uninstalls: ok Only real blocker is the minor licensing tag, since it's mostly cosmetic, please fix prior to importing. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review