https://bugzilla.redhat.com/show_bug.cgi?id=1021721 --- Comment #25 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text (In reply to Erik Johnson from comment #24) > OK, I've updated the SPEC. I corrected the bad dates (wrong day of week) and > added the %doc line. This changed in meantime ;). See above. > string_format.py has been removed from the project I still see it: SaltTesting-2015.5.8/salttesting/pylintplugins/string_format.py /usr/lib/python2.7/site-packages/salttesting/pylintplugins/string_format.py /usr/lib/python2.7/site-packages/salttesting/pylintplugins/string_format.pyc /usr/lib/python2.7/site-packages/salttesting/pylintplugins/string_format.pyo > I have fixed the %build step (needed to edit the copypasta there). Yes. Please also move 'rm -rf %{srcname}.egg-info' to %prep. Does the package support Python3? There was a change to the guidelines today: It is now mandatory that modules which support python3 be packaged for python3. Python modules which support both python2 and python3 may be packages for both, or just python3. Packaging of modules which support only python2 are unaffected. * https://fedoraproject.org/wiki/Packaging:Python * https://fedoraproject.org/w/index.php?title=Packaging%3APython&diff=413621&oldid=409012 * https://fedorahosted.org/fpc/ticket/526 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review