[Bug 1222272] Review Request: php-pimple1 - A simple dependency injection container for PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1222272



--- Comment #5 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to Remi Collet from comment #4)
> [!]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
>   You cannot obsolete yourself (see rpmlint warning)
>   I think it is safe to drop the provide (php-Pimple still exists)
>   and package using it, should use composer require.
> 
> [!]: Package does not generate any conflict.
>   As this package is not PSR-0 compliant, perhaps you can 
>   use another top dir (ex /usr/share/php/Pimple1) and thus 
>   avoid the conflicts with new version ?

I was against this when I first read it, but the more I thought about it the
more I liked it.  Implemented.  Diff =
https://github.com/siwinski/rpms/commit/2bff02a18a7c12c39c8be74973266f4451ca19f1


> I can't test what happens when php-pimple1 and php-Pimple 3 are in the repo.
> Will the package be update, or replace ?

adamwill updated php-Pimple for owncloud --
https://admin.fedoraproject.org/updates/search/php-Pimple-3.0.0

Note that for the long-run I still want to move ahead with bug 1131731 so the
extension is available as well.  I will update that review request soon.



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/2bff02a18a7c12c39c8be74973266f4451ca19f1/php-pimple1/php-pimple1.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-pimple1-1.1.1-3.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]