https://bugzilla.redhat.com/show_bug.cgi?id=1222709 --- Comment #2 from Rafael Aquini <aquini@xxxxxxxxx> --- (In reply to Douglas Schilling Landgraf from comment #1) > Hi Rafael, > > I saw Marcelo took the bug, here two quick comments, from: > https://fedoraproject.org/wiki/Packaging:ReviewGuidelines > > #1) > MUST: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package must be included in %license.[4] > > > #2) > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Exceptions_2 > Exceptions > > There is no need to include the following packages or their dependencies as > BuildRequires because they would occur too often. These packages are > considered the minimum build environment. > > <snip> > gcc-c++ > </snip> Thanks for taking the time to review this work Douglas! Here's the adjusted spec, following your feedback: Spec URL: https://aquini.fedorapeople.org/memkind/memkind.spec SRPM URL: https://aquini.fedorapeople.org/memkind/memkind-0.2.2-2.20150518git.fc23.src.rpm Koji scratch-Build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=9782909 -- Rafael -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review