https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #8 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Full review done: Good: -------- - rpmlint checks return: angelscript-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning can be ignored - package meets naming guidelines - package meets packaging guidelines - license (zlib) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Should fix: -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc sdk/docs/manual/*" to avoid including the files under dk/docs/articles in both the main package and the -devel package No blockers: Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review