https://bugzilla.redhat.com/show_bug.cgi?id=1103414 --- Comment #10 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #9) > While I don't like triggers and having files generated at install time, the > actual method of using > this library recommended by upstream is including both jquery.js and > jquery-migrate.js, so what > you're doing is simply a convenience for package consumers, so I guess this > outweighs the issue > of not being able to easily verify the jquery+migrate{,.min}.js contents > using rpm -V. I added a %verifyscript to address this concern. Now if these generated files are not consistent with the already-verified RPM-installed files, rpm -V will complain: ---------- % rpm -Vv js-jquery-migrate ......... /usr/share/doc/js-jquery-migrate ......... d /usr/share/doc/js-jquery-migrate/AUTHORS.txt ......... d /usr/share/doc/js-jquery-migrate/CONTRIBUTING.md ......... d /usr/share/doc/js-jquery-migrate/LICENSE-MIT ......... d /usr/share/doc/js-jquery-migrate/README.md ......... /usr/share/javascript/jquery-migrate ......... /usr/share/javascript/jquery-migrate/jquery-migrate.js ......... /usr/share/javascript/jquery-migrate/jquery-migrate.min.js % sudo truncate --size=10 /usr/share/javascript/jquery-migrate/jquery+migrate.js % rpm -Vv js-jquery-migrate ......... /usr/share/doc/js-jquery-migrate ......... d /usr/share/doc/js-jquery-migrate/AUTHORS.txt ......... d /usr/share/doc/js-jquery-migrate/CONTRIBUTING.md ......... d /usr/share/doc/js-jquery-migrate/LICENSE-MIT ......... d /usr/share/doc/js-jquery-migrate/README.md ......... /usr/share/javascript/jquery-migrate ......... /usr/share/javascript/jquery-migrate/jquery-migrate.js ......... /usr/share/javascript/jquery-migrate/jquery-migrate.min.js The file /usr/share/javascript/jquery+migrate.js does not match the installed versions of js-jquery1 and js-jquery-migrate. Please reinstall these packages to resolve this issue. ----------- > MUST: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package must be included in %license. > > -> Please mark the LICENSE-MIT file with %license macro. Fixed. > MUST: Packages must NOT bundle copies of system libraries. > > It's bundling qunit (https://qunitjs.com), even if it isn't used unless > enable_tests is set to 1. > -> Please unbundle. Fixed. > SHOULD: The reviewer should test that the package functions as described. A > package should not segfault instead of running, for example. > > You should try to run the testsuite at build time. You have the following > comment in your spec: > # disabled due to missing dependencies (that likely won't run in koji anyway) > What is missing apart from qunit? Its dependencies. (Including what will be the fourth nodejs command line argument parsing library we've packaged. Yeesh!) -- Spec: https://patches.fedorapeople.org/jquery/js-jquery-migrate.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery-migrate-1.2.1-6.fc20.src.rpm * Sat May 16 2015 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 1.2.1-6 - use %%license where available - remove bundled qunit - add %%verifyscript for files generated post-install -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review