[Bug 1221948] Review Request: xdg-app - Application deployment framework for desktop apps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1221948

Florian "der-flo" Lehner <dev@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |dev@xxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |dev@xxxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Florian "der-flo" Lehner <dev@xxxxxxxxxxx> ---
Hi David!

I will do the review.

Please upload the latest spec and srpm for the review.

Diff spec file in url and in SRPM
---------------------------------
--- /home/flo/review/1221948-xdg-app/srpm/xdg-app.spec    2015-05-15
14:44:30.848836938 +0200
+++ /home/flo/review/1221948-xdg-app/srpm-unpacked/xdg-app.spec    2015-05-15
11:58:13.000000000 +0200
@@ -1,5 +1,5 @@
 Name:           xdg-app
 Version:        0.2
-Release:        2%{?dist}
+Release:        1%{?dist}
 Summary:        Application deployment framework for desktop apps

@@ -10,6 +10,4 @@
 # profile.d snippet, suggested by Alex.
 Source1:        xdg-app.sh
-#
https://github.com/alexlarsson/xdg-app/commit/a1892ee8b04c55cd96cfcc3bfb562d75683a46c4
-Patch0:         xdg-app-0.2-fix-autoptr-old-glib.patch

 BuildRequires:  pkgconfig(gio-unix-2.0)
@@ -31,5 +29,4 @@
 %prep
 %setup -q
-%autosetup


@@ -61,7 +58,4 @@

 %changelog
-* Fri May 15 2015 David King <amigadave@xxxxxxxxxxxxx> - 0.2-2
-- Add upstream patch to build against older GLib
-
 * Fri May 15 2015 David King <amigadave@xxxxxxxxxxxxx> - 0.2-1
 - Update to 0.2

There is one rpmlint-warning:
xdg-app.x86_64: W: non-conffile-in-etc /etc/profile.d/xdg-app.sh
To fix this take a look at
https://fedoraproject.org/wiki/Common_Rpmlint_issues#non-conffile-in-etc

Cheers,
 Florian

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]