[Bug 1192059] Review Request: gtk-sharp3 - GTK 3 sharp for Mono

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1192059

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #21 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Upstream URL changed to http://www.mono-project.com/docs/gui/gtksharp/.

Some minor issues are marked below with ? or !. Please fix them up (or comment
why they are ok as is). Package is APPROVED.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "GPL (v2) (with
     incorrect FSF address)", "Unknown or generated". 355 files have
     unknown license. Detailed output of licensecheck in /var/tmp/1192059
     -gtk-sharp3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/mono/gac/pango-sharp
     (gtk-sharp2), /usr/lib/mono/gac/gtk-dotnet(gtk-sharp2),
     /usr/lib/mono/gac/atk-sharp(gtk-sharp2), /usr/lib/mono/gac/glib-sharp
     (gtk-sharp2), /usr/lib/mono/gac/gtk-sharp(gtk-sharp2),
     /usr/lib/mono/gac/gdk-sharp(gtk-sharp2)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[?]: Package contains the mandatory BuildRequires and Requires:.
     Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
     echo $version)) missing?


===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gtk-
     sharp3-gapi , gtk-sharp3-doc


[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
     Note: gtk-sharp3-gapi : /usr/lib64/pkgconfig/gapi-3.0.pc
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define _monodir
     %{_prefix}/lib/mono, %define _monogacdir %{_monodir}/gac
Those should be changed to %global.

[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.

===== EXTRA items =====

Generic:
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
An upstream issue.

[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2467840 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gtk-sharp3-2.99.3-9.fc23.x86_64.rpm
          gtk-sharp3-gapi-2.99.3-9.fc23.x86_64.rpm
          gtk-sharp3-devel-2.99.3-9.fc23.x86_64.rpm
          gtk-sharp3-doc-2.99.3-9.fc23.noarch.rpm
          gtk-sharp3-2.99.3-9.fc23.src.rpm
gtk-sharp3.x86_64: W: unstripped-binary-or-object
/usr/lib64/libmono-profiler-gui-thread-check.so.0.0.0
gtk-sharp3-gapi.x86_64: W: only-non-binary-in-usr-lib
gtk-sharp3-gapi.x86_64: W: no-documentation
gtk-sharp3-gapi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/pkgconfig/gapi-3.0.pc
gtk-sharp3-gapi.x86_64: W: no-manual-page-for-binary gapi3-parser
gtk-sharp3-gapi.x86_64: W: no-manual-page-for-binary gapi3-fixup
gtk-sharp3-gapi.x86_64: W: no-manual-page-for-binary gapi3-codegen
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libgiosharpglue-3.so
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libpangosharpglue-3.so
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libgtksharpglue-3.so
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libatksharpglue-3.so
gtk-sharp3-devel.x86_64: W: no-documentation
gtk-sharp3-doc.noarch: W: only-non-binary-in-usr-lib
gtk-sharp3-doc.noarch: W: no-documentation
gtk-sharp3.src:3: E: hardcoded-library-path in %{_prefix}/lib/mono
gtk-sharp3.src:105: E: hardcoded-library-path in %{_prefix}/lib/gapi-3.0
gtk-sharp3.src:106: E: hardcoded-library-path in
%{_prefix}/lib/gapi-3.0/gapi_codegen.exe
gtk-sharp3.src:107: E: hardcoded-library-path in
%{_prefix}/lib/gapi-3.0/gapi-fixup.exe
gtk-sharp3.src:108: E: hardcoded-library-path in
%{_prefix}/lib/gapi-3.0/gapi-parser.exe
gtk-sharp3.src:109: E: hardcoded-library-path in
%{_prefix}/lib/gapi-3.0/gapi_pp.pl
gtk-sharp3.src:110: E: hardcoded-library-path in
%{_prefix}/lib/gapi-3.0/gapi2xml.pl
gtk-sharp3.src:120: E: hardcoded-library-path in
%{_prefix}/lib/monodoc/sources/*
5 packages and 0 specfiles checked; 8 errors, 14 warnings.

All OK.


Rpmlint (installed packages)
----------------------------
gtk-sharp3-doc.noarch: W: only-non-binary-in-usr-lib
gtk-sharp3-doc.noarch: W: no-documentation
gtk-sharp3-gapi.x86_64: W: only-non-binary-in-usr-lib
gtk-sharp3-gapi.x86_64: W: no-documentation
gtk-sharp3-gapi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/pkgconfig/gapi-3.0.pc
gtk-sharp3-gapi.x86_64: W: no-manual-page-for-binary gapi3-parser
gtk-sharp3-gapi.x86_64: W: no-manual-page-for-binary gapi3-fixup
gtk-sharp3-gapi.x86_64: W: no-manual-page-for-binary gapi3-codegen
gtk-sharp3.x86_64: W: unstripped-binary-or-object
/usr/lib64/libmono-profiler-gui-thread-check.so.0.0.0
gtk-sharp3.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libmono-profiler-gui-thread-check.so.0.0.0 /lib64/libm.so.6
gtk-sharp3.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libmono-profiler-gui-thread-check.so.0.0.0 /lib64/librt.so.1
gtk-sharp3.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libmono-profiler-gui-thread-check.so.0.0.0 /lib64/libdl.so.2
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libgiosharpglue-3.so
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgiosharpglue-3.so /lib64/libgio-2.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgiosharpglue-3.so /lib64/libgobject-2.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgiosharpglue-3.so /lib64/libglib-2.0.so.0
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libpangosharpglue-3.so
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpangosharpglue-3.so /lib64/libpango-1.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpangosharpglue-3.so /lib64/libgobject-2.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpangosharpglue-3.so /lib64/libglib-2.0.so.0
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libgtksharpglue-3.so
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libgdk-3.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libpangocairo-1.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libpango-1.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libatk-1.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libcairo-gobject.so.2
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libcairo.so.2
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libgdk_pixbuf-2.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libgio-2.0.so.0
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgtksharpglue-3.so /lib64/libglib-2.0.so.0
gtk-sharp3-devel.x86_64: W: unstripped-binary-or-object
/usr/lib64/libatksharpglue-3.so
gtk-sharp3-devel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libatksharpglue-3.so /lib64/libglib-2.0.so.0
gtk-sharp3-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 33 warnings.

All OK.

Requires
--------
gtk-sharp3-doc (rpmlib, GLIBC filtered):
    monodoc

gtk-sharp3-gapi (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/perl
    /usr/bin/pkg-config
    mono(System)
    mono(System.Core)
    mono(System.Xml)
    mono(mscorlib)
    perl(XML::LibXML)

gtk-sharp3 (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libglib-2.0.so.0()(64bit)
    libm.so.6()(64bit)
    libmono-2.0.so.1()(64bit)
    libmono-2.0.so.1(VER_1)(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    mono(System)
    mono(System.Core)
    mono(System.Drawing)
    mono(atk-sharp)
    mono(cairo-sharp)
    mono(gdk-sharp)
    mono(gio-sharp)
    mono(glib-sharp)
    mono(gtk-sharp)
    mono(mscorlib)
    mono(pango-sharp)
    rtld(GNU_HASH)

gtk-sharp3-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    gtk-sharp3(x86-64)
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo-gobject.so.2()(64bit)
    libcairo.so.2()(64bit)
    libgdk-3.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-3.so.0()(64bit)
    libmono-profiler-gui-thread-check.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    pkgconfig
    pkgconfig(gdk-sharp-3.0)
    pkgconfig(gio-sharp-3.0)
    pkgconfig(glib-sharp-3.0)
    pkgconfig(gtk-sharp-3.0)
    rtld(GNU_HASH)



Provides
--------
gtk-sharp3-doc:
    gtk-sharp3-doc

gtk-sharp3-gapi:
    gtk-sharp3-gapi
    gtk-sharp3-gapi(x86-64)
    mono(gapi-fixup)
    mono(gapi-parser)
    mono(gapi_codegen)
    pkgconfig(gapi-3.0)

gtk-sharp3:
    gtk-sharp3
    gtk-sharp3(x86-64)
    libmono-profiler-gui-thread-check.so.0()(64bit)
    mono(atk-sharp)
    mono(cairo-sharp)
    mono(gdk-sharp)
    mono(gio-sharp)
    mono(glib-sharp)
    mono(gtk-dotnet)
    mono(gtk-sharp)
    mono(pango-sharp)

gtk-sharp3-devel:
    gtk-sharp3-devel
    gtk-sharp3-devel(x86-64)
    libatksharpglue-3.so()(64bit)
    libgiosharpglue-3.so()(64bit)
    libgtksharpglue-3.so()(64bit)
    libpangosharpglue-3.so()(64bit)
    pkgconfig(gdk-sharp-3.0)
    pkgconfig(gio-sharp-3.0)
    pkgconfig(glib-sharp-3.0)
    pkgconfig(gtk-dotnet-3.0)
    pkgconfig(gtk-sharp-3.0)



Source checksums
----------------
http://ftp.acc.umu.se/pub/gnome/sources/gtk-sharp/2.99/gtk-sharp-2.99.3.tar.xz
:
  CHECKSUM(SHA256) this package     :
6440f571416267ae0cb5698071d087b31e3084693fa2c829b1db37ca7ea2c3a2
  CHECKSUM(SHA256) upstream package :
6440f571416267ae0cb5698071d087b31e3084693fa2c829b1db37ca7ea2c3a2


AutoTools: Obsoleted m4s found
------------------------------
  AM_PROG_LIBTOOL found in: gtk-sharp-2.99.3/configure.ac:72


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -b 1192059
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++, Perl
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP,
Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]