https://bugzilla.redhat.com/show_bug.cgi?id=1215728 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(karlthered@gmail. | |com) | --- Comment #4 from Haïkel Guémar <karlthered@xxxxxxxxx> --- Few minor points to fix before importing into dist-git: * There's a typo in License tag, it's *ASL 2.0* * sed -i '/%defattr(-,root,root,-)/d' *.spec * License file is not included, since you're also an upstream developer, I trust you to ensure that it will be included in future releases. Since this package complies with Fedora Packaging Guidelines, I hereby approve it into Fedora Packages Collection. Please submit a SCM request. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 12 files have unknown license. Detailed output of licensecheck in /home/haikel/1215728-openstack-gnocchi/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/ceilometer [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- gnocchi , openstack-gnocchi-api , openstack-gnocchi-carbonara , openstack-gnocchi-indexer-sqlalchemy , openstack-gnocchi-statsd , openstack-gnocchi-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-gnocchi-1.0.0-1.fc23.noarch.rpm openstack-gnocchi-api-1.0.0-1.fc23.noarch.rpm openstack-gnocchi-carbonara-1.0.0-1.fc23.noarch.rpm openstack-gnocchi-indexer-sqlalchemy-1.0.0-1.fc23.noarch.rpm openstack-gnocchi-statsd-1.0.0-1.fc23.noarch.rpm openstack-gnocchi-doc-1.0.0-1.fc23.noarch.rpm openstack-gnocchi-1.0.0-1.fc23.src.rpm python-gnocchi.noarch: W: invalid-license APL 2.0 python-gnocchi.noarch: W: no-documentation openstack-gnocchi-api.noarch: W: invalid-license APL 2.0 openstack-gnocchi-api.noarch: W: no-documentation openstack-gnocchi-api.noarch: E: non-readable /etc/gnocchi/gnocchi.conf 0640L openstack-gnocchi-api.noarch: W: no-manual-page-for-binary gnocchi-api openstack-gnocchi-carbonara.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end openstack-gnocchi-carbonara.noarch: W: spelling-error %description -l en_US ceph -> Cepheus openstack-gnocchi-carbonara.noarch: W: invalid-license APL 2.0 openstack-gnocchi-carbonara.noarch: W: no-documentation openstack-gnocchi-carbonara.noarch: W: no-manual-page-for-binary carbonara-create openstack-gnocchi-carbonara.noarch: W: no-manual-page-for-binary carbonara-dump openstack-gnocchi-carbonara.noarch: W: no-manual-page-for-binary carbonara-update openstack-gnocchi-indexer-sqlalchemy.noarch: W: invalid-license APL 2.0 openstack-gnocchi-indexer-sqlalchemy.noarch: W: no-documentation openstack-gnocchi-indexer-sqlalchemy.noarch: W: no-manual-page-for-binary gnocchi-dbsync openstack-gnocchi-statsd.noarch: W: invalid-license APL 2.0 openstack-gnocchi-statsd.noarch: W: no-documentation openstack-gnocchi-statsd.noarch: W: no-manual-page-for-binary gnocchi-statsd openstack-gnocchi-doc.noarch: W: invalid-license APL 2.0 openstack-gnocchi.src: W: invalid-license APL 2.0 openstack-gnocchi.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 5) 7 packages and 0 specfiles checked; 1 errors, 21 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- openstack-gnocchi-statsd (rpmlib, GLIBC filtered): /usr/bin/python2 python-gnocchi python-oslo-log python-oslo-utils python-six python-trollius openstack-gnocchi-doc (rpmlib, GLIBC filtered): python-gnocchi openstack-gnocchi-indexer-sqlalchemy (rpmlib, GLIBC filtered): /usr/bin/python2 python-gnocchi python-oslo-db python-oslo-utils python-sqlalchemy python-stevedore python-swiftclient pytz python-gnocchi (rpmlib, GLIBC filtered): PyYAML numpy python(abi) python-flask python-futures python-jinja2 python-keystonemiddleware python-msgpack python-oslo-config python-oslo-db python-oslo-log python-oslo-policy python-oslo-serialization python-oslo-sphinx python-oslo-utils python-pandas python-pecan python-pytimeparse python-requests python-retrying python-six python-sqlalchemy python-sqlalchemy-utils python-stevedore python-swiftclient python-sysv_ipc python-tooz python-trollius python-voluptuous python-werkzeug pytz openstack-gnocchi-carbonara (rpmlib, GLIBC filtered): /usr/bin/python2 python-futures python-gnocchi python-msgpack python-oslo-utils python-pandas python-retrying python-swiftclient python-tooz openstack-gnocchi-api (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 PyYAML config(openstack-gnocchi-api) python-flask python-gnocchi python-jinja2 python-keystonemiddleware python-oslo-db python-oslo-policy python-oslo-serialization python-oslo-utils python-pecan python-pytimeparse python-requests python-six python-sqlalchemy python-sqlalchemy-utils python-stevedore python-tooz python-voluptuous python-werkzeug Provides -------- openstack-gnocchi-statsd: openstack-gnocchi-statsd openstack-gnocchi-doc: openstack-gnocchi-doc openstack-gnocchi-indexer-sqlalchemy: openstack-gnocchi-indexer-sqlalchemy python-gnocchi: python-gnocchi openstack-gnocchi-carbonara: openstack-gnocchi-carbonara openstack-gnocchi-api: config(openstack-gnocchi-api) openstack-gnocchi-api Source checksums ---------------- https://pypi.python.org/packages/source/g/gnocchi/gnocchi-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 094162f53b9acf12e67e3190394f111721e2204785743dabbe258f8bc14ed1a2 CHECKSUM(SHA256) upstream package : 094162f53b9acf12e67e3190394f111721e2204785743dabbe258f8bc14ed1a2 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1215728 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review