[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1221469



--- Comment #4 from Michal Srb <msrb@xxxxxxxxxx> ---
(In reply to gil cattaneo from comment #1)

> [?]: All build dependencies are listed in BuildRequires, except for any that
>      are listed in the exceptions section of Packaging Guidelines.
>      Note: Using prebuilt rpms.
>  jruby-openssl:0.8.2 see
> ./ruby-tools/src/main/java/de/saumya/mojo/ruby/gems/GemsInstaller.java
>  https://github.com/jruby/jruby-openssl

This fine should by fine IMO.

> [?]: Package contains no bundled libraries without FPC exception.
>  ./ruby-tools/src/main/resources/rails-templates/datamapper/application.rb
>  ./ruby-tools/src/main/resources/rails-templates/datamapper/config.rb
>  ./ruby-tools/src/main/resources/rails-templates/datamapper/database.yml.rb
>  ./ruby-tools/src/main/resources/rails-templates/datamapper/gemfile.rb
>  https://github.com/datamapper
> 

Good catch. I missed those. I will check whether those are needed for now. If
not, I will remove them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]