https://bugzilla.redhat.com/show_bug.cgi?id=830869 --- Comment #28 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #27) Thanks for the review. > Please add %global _docdir_fmt %{name}. Currently hpl-common has files in > /usr/share/doc/hpl-common which is confusing and unnecessary. > Fixed > Documentation should be in an unversioned directory. > [https://fedoraproject.org/wiki/Changes/UnversionedDocdirs] > Fixed, it was because this review request is very very old, and in that good old times, documentation was versioned :) > Use %license for COPYRIGHT. > [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text] > Fixed, the same as previous, there was no %license when this review request was submitted. > The binary currently tries to open /etc/hpl/HPL.dat and segfaults. I think > it should be patched to use the new location. > Please see previous discussion on HPL.dat location. I finally moved HPL.dat to /usr/share/hpl, but I am not sure whether it is good thing to add a fallback for HPL to read the file from there, probably it isn't. Nevertheless it shouldn't coredump. I patched it to cleanly exit. > README.Fedora still refers to mpich2. It's mpich now. > Fixed and also updated regarding HPL.dat location. > Shouldn't this be run in %check? It would test both mpi implementations on > all archs. > I am currently not sure. Did you mean running the HPL benchmark by hand over all available implementations? And with which configuration? With the supplied example HPL.dat? What number of processes to use? One? Is it good thing to do? > [?]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/hpl, /usr/share/doc/hpl-2.1 > /usr/share/hpl should be owned. > /usr/share/doc/hpl too. > It should be fixed now. > Generic: > [!]: Uses parallel make %{?_smp_mflags} macro. > It probably should. > Unfortunately it cannot, because the Makefile is broken. I added comment about it. > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define dobuild() cp > setup/Make.Linux_PII_CBLAS_gm Make.$MPI_COMPILER make > TOPdir="%{_builddir}/%{name}-%{version}" arch=$MPI_COMPILER > ARCH=$MPI_COMPILER \\%if %{with openblas} LAlib=-lopenblas %endif > Please use %global > Fixed New version: Spec URL: http://jskarvad.fedorapeople.org/hpl/hpl.spec SRPM URL: http://jskarvad.fedorapeople.org/hpl/hpl-2.1-6.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review