https://bugzilla.redhat.com/show_bug.cgi?id=1098965 Stefan Cornelius <scorneli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment|0 |1 #1023527 is| | obsolete| | --- Comment #11 from Stefan Cornelius <scorneli@xxxxxxxxxx> --- Created attachment 1024818 --> https://bugzilla.redhat.com/attachment.cgi?id=1024818&action=edit Addressed issued found during package audit. (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #10) Thank you for the audit! New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9717792 > > %files > > %doc README LICENSE.TXT ChangeLog LICENSE_LLVM.TXT > > https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Fixed by using %license > > %files devel > > %doc > > > %files java > > %doc > > An empty %doc line is a no-op. Remember, %doc is not a section in the spec > file like %build or %install. Fixed by removing %doc. > > %{_includedir}/* > > %exclude %{_libdir} > > %{_libdir}/*.so > > %{_libdir}/pkgconfig/* > > So, somebody added this unusual %exclude line without commenting on it > anywhere in the spec file. The %changelog doesn't tell why this was added. > IMO, it is the cause of a broken build as it hides files that ought to be > packaged. Just examine the contents of the capstone-devel package. There is > no build-time library! Can't explain this one. brainfart? Fixed. > > %{_javadir}/ > > %{_javadir}/%{name}.jar > > The first line already includes %{_javadir} and everything in it. The second > line is redundant. > Fixed by removing redundant line. > > https://kojipkgs.fedoraproject.org//work/tasks/6949/9686949/build.log > > Notice the errors in make check. Solution: Adjust runtime linker's search > path to make it find the freshly build shared lib. Fixed by adopting the search path, as suggested. All checks work and pass now. > > > + make -j16 > > CC cs.o > > CC MCInstrDesc.o > > CC SStream.o > > CC utils.o > > Build output is non-verbose. One cannot verify which compiler flags have > been used actually: > https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags Fixed by enabling verbose mode. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review