https://bugzilla.redhat.com/show_bug.cgi?id=1165620 --- Comment #13 from Petr Šabata <psabata@xxxxxxxxxx> --- So, after checking your long dep list: Missing build-time dependencies: - perl itself - it is called in the spec file - Log::Log4perl::Appender::File - Log::Log4perl::Appender::Screen - Log::Log4perl::Layout::PatternLayout - Log::Log4perl::Layout::SimpleLayout - these are via tests -> Biber -> Biber::Config - re - this is via tests -> Biber -> Biber::Utils - Text::BibTeX::Name - Text::BibTeX::NameFormat - these are via tests -> Biber::Input::file::bibtex I think you can safely drop the following build-time deps: - Business::ISBN - Business::ISSN - Business::ISMN - this code isn't tested - Config::AutoConf - Encode::EUCJPASCII - Encode::HanExtra - Encode::JIS2K - ExtUtils::LibBuilder - these aren't actually used anywhere - Getopt::Long - only used by the script and it's not tested - List::MoreUtils - again, not used anywhere - LWP::Simple - LWP::Protocol::https - Mozila::CA - this code isn't tested - Pod::Usage - only used by the script, not tested - Readonly - Readonly::XS - not tested; furthermore, the XS variant is only recommended for improved performance - Unicode::Collate - amusing, isn't it? It's not actually used anywhere; some of its submodules are but not this one -- and with the dependency constraint removed, you can just drop this completely - XML::LibXSLT - this code isn't tested - XML::Writer::String - this isn't used anywhere, not even mentioned in META; where did you find it?... Now, for the runtime dependencies. These can be dropped from the list because rpmbuild's generators will automagically find them for you: - autovivification - Data::Dump - Data::Compare - Data::Simple - File::Slurp - IPC::Cmd - IPC::Run3 - List::AllUtils - Log::Log4perl - Regexp::Common - Unicode::GCString - URI - XML::Writer And these just aren't needed at all: - Encode::EUCJPASCII - Encode::HanExtra - Encode::JIS2K - List::MoreUtils - Unicode::Collate - XML::Writer::String Note Text::BibTeX gets autodetected too, however, it's missing the version constraint. Therefore keep your explicit runtime dependency and filter out the autogenerated one, like this, on one line: %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\(Text::BibTeX\\)$ You also need to add this to your runtime dep list, the generators won't pick it up: - Unicode::Collate::Locale That should be all for the deps, next... The license tag is incorrect. The README file states the distribution is licensed under GPL+ or Artistic 2.0, however, all the code mentions Artistic 2.0 only. I would suggest using `(GPL+ or Artistic 2.0) and Artistic 2.0' here. And perhaps package TODO.org as %doc, too. Hopefully that's all there is to this review :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review