[Bug 1220131] Review Request: perl-Test-Deep-Type - Test::Deep plugin for validating type constraints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1220131

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Deep-Type-0.006-1.fc23.noarch.rpm | sort | uniq
-c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Exporter)
      1 perl(Safe::Isa)
      1 perl(Scalar::Util)
      1 perl(Test::Deep::Cmp)
      1 perl(Try::Tiny)
      1 perl(namespace::clean)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Deep-Type-0.006-1.fc23.noarch.rpm | sort | uniq
-c
      1 perl(Test::Deep::Type) = 0.006
      1 perl-Test-Deep-Type = 0.006-1.fc23
Binary provides are Ok.

$ rpmlint ./perl-Test-Deep-Type*
perl-Test-Deep-Type.noarch: W: spelling-error %description -l en_US coderef ->
code ref, code-ref, coder
perl-Test-Deep-Type.noarch: W: spelling-error %description -l en_US bool ->
biol, boil, book
perl-Test-Deep-Type.src: W: spelling-error %description -l en_US coderef ->
code ref, code-ref, coder
perl-Test-Deep-Type.src: W: spelling-error %description -l en_US bool -> biol,
boil, book
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

FIX: Please add BR perl(if), perl(overload), perl(strict) and
     perl(warnings)

TODO: You can add examples/ to the doc.

Otherwise package is good.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]