https://bugzilla.redhat.com/show_bug.cgi?id=1197126 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- `examples/eumm-and-test-manifest/MyModule/.cvsignore' is write-protected, remove it with --force. Consider using %{__perl} instead of $(perl -MConfig -e 'print $Config{startperl}'). I think it's way more readable. Also, if you really want the latter, I suggest moving the perl(Config) build-time dependency from the `Tests' section to line #14. If you really feel like it, you can package the script and examples as subpackages. See the first paragraph of https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios There aren't any real blockers. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review