https://bugzilla.redhat.com/show_bug.cgi?id=1063060 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Mo Morsi from comment #5) > The rubygem-websocket spec suite depends on the "its" gem which isn't in > Fedora yet, so left that commented for now. Better part of the test suite can be enabled as simple as: find spec -name *.rb | xargs sed -i '/its/ s/^/#/' BTW if you keep the test suite disabled, the BR: rubygem(rspec) is worthless. * Superfluous requires - The requires are not auto-generated during build. Please remove them. * Missing period after description. - The -doc subpackage description should end by period. * Mark documentation by %doc macro - The CHANGELOG.md is documentation and hence it should be marked by %doc macro.(In reply to Mo Morsi from comment #5) * Unowned directory - I believe that the %{gem_instdir}/spec/* makes the RPM to own just the content of the directory, not the directory itself. The above points are just minor nits and the package otherwise looks good => APPROVED but please fix the issues prior importing the package into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review