[Bug 1215762] Review Request: py4j - Dynamically access in Python programs to arbitrary Java objects (for Python 2 and 3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1215762

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: py4j - Py4J |Review Request: py4j -
                   |enables Python programs to  |Dynamically access in
                   |dynamically access          |Python programs to
                   |arbitrary Java objects (for |arbitrary Java objects (for
                   |Python 2 and 3)             |Python 2 and 3)



--- Comment #31 from Raphael Groner <projects.rg@xxxxxxxx> ---
Spec URL: https://raphgro.fedorapeople.org/review/py/py4j/py4j.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/py/py4j/py4j-0.9-0.2.pre.20141101git9a8ab93.fc22.src.rpm
Description: Dynamically access in Python programs to arbitrary Java objects
Fedora Account System Username: raphgro

rawhide scratch (Java 8 and Python 2+3):
http://koji.fedoraproject.org/koji/taskinfo?taskID=9671013

epel7 scratch (Java 7 and Python 2 only):
http://koji.fedoraproject.org/koji/taskinfo?taskID=9671042

Note: There was a lot of activity at upstream in the last few days. So I'm
going to provide a new snapshot for just another 0.3 release. But there's a bug
with sphinx now.


--
(In reply to gil cattaneo from comment #30)
> Forgotten
> invalid-url URL: https://py4j.sf.net <urlopen error [Errno 111] Connection
> refused>
> Please, use http://py4j.sourceforge.net/

Fixed. Replaced https with http - it does not seem to like ssl with the short
sf domain.

(In reply to gil cattaneo from comment #29)
> ISSUES:
> 
> [?]: Package contains no bundled libraries without FPC exception.
>  py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-java/src/py4j/Base64.java

This file is obviously taken from MiGBase64 that's licensed with BSD and can be
found as the original project separately at sourceforge, see also inside the
source file header with an included BSD statement. There are some forks also at
GitHub. But I fail to find any Fedora package. Not sure if we have to care.
Maybe use base64coder or java-base64 as a replacement?
http://migbase64.cvs.sourceforge.net/viewvc/migbase64/migbase64/src/util/Base64.java?view=markup
http://sourceforge.net/projects/migbase64/

> [!]: Uses parallel make %{?_smp_mflags} macro.

What to do here exactly? Should I patch the setup.py internal logic that builds
the CPython stuff?

> py4j-doc.noarch: W: hidden-file-or-dir
> /usr/share/doc/py4j-doc/html/.buildinfo
> Please, remove
> 
> py4j-java.noarch: W: dangling-relative-symlink /usr/share/py4j/*.jar
> %{javadir}/py4j/*.jar
> Please, use
> %mvn_artifact %{name}-java/pom.xml %{name}-java/%{name}.jar
> ...
> ln -sf %{javadir}/%{name}/%{name}.jar %{buildroot}%{_datadir}/%{name}
> 
> Please, remove all bundled JS libraries
...
> py4j-doc.noarch: W: wrong-file-end-of-line-encoding
...
> Please remove these files, used only for generate documentation
...

All fixed.

> Diff spec file in url and in SRPM (see above)

Not clear to me what that means?

(In reply to gil cattaneo from comment #28)
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "Unknown or generated". 50 files have unknown license.
     Detailed output of licensecheck in /home/gil/1215762-py4j/review-
     py4j/licensecheck.txt
==> I guess all of those files can be considered to be BSD cause it's the main
upstream license for the whole project.


py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-java/src/py4j/commands/ExceptionCommand.java
==> Not sure why not licensed inside. Have to invest.

 py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/setup.py
==> This is configuration for setuptools.

 py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/src/py4j/compat.py

py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/src/py4j/finalizer.py

py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/src/py4j/java_collections.py
==> Not sure why not licensed inside. Have to invest.


py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/src/py4j/java_gateway.py
 py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/src/py4j/protocol.py
==> Not sure why not licensed inside. Have to invest.

 py4j-9a8ab938b4024af8f0455edb54f80fdb5195968b/py4j-python/src/py4j/version.py
==> Very short file that is patched to nearly emptiness in spec file.

...
> py4j.src: W: name-repeated-in-summary C Py4J

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]