[Bug 1210983] Review Request: python-vcrpy - Automatically mock your HTTP interactions to simplify and speed up testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1210983

Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
* Rpmlint can safely be ignored:
python3-vcrpy.noarch: W: spelling-error %description -l en_US yaml -> yam,
yams, yawl
python3-vcrpy.noarch: W: no-documentation
python-vcrpy.noarch: E: explicit-lib-dependency python-contextlib2
python-vcrpy.noarch: E: explicit-lib-dependency python3-contextlib2
python-vcrpy.noarch: W: spelling-error %description -l en_US yaml -> yam, yams,
yawl
python-vcrpy.noarch: W: no-documentation
python-vcrpy.src: W: spelling-error %description -l en_US yaml -> yam, yams,
yawl
python-vcrpy.src:135: W: macro-in-comment %doc
python-vcrpy.src:136: W: macro-in-comment %license
python-vcrpy.src:144: W: macro-in-comment %doc
python-vcrpy.src:145: W: macro-in-comment %license
3 packages and 0 specfiles checked; 2 errors, 9 warnings.

* Spec is clean
* License is MIT and is shipped in the sources
! The LICENSE and README file can now be marked as %doc
* No bundle in the sources
* Builds cleanly on F22 (via mock) (not in F21 but that's likely an
updates-testing issue)
* Consistent usage of the macros
* Upstream sources:
6f40f3e0fbde03ca44ccdff2711cac39dcd6d2354795582f8bf6f98376fa0b62 
vcrpy-1.4.2.tar.gz
* srpm sources:
6f40f3e0fbde03ca44ccdff2711cac39dcd6d2354795582f8bf6f98376fa0b62 
python-vcrpy-1.4.2-1.fc21.src/vcrpy-1.4.2.tar.gz

This looks all good to me

This package is APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]