https://bugzilla.redhat.com/show_bug.cgi?id=1218362 --- Comment #7 from Andreas Gruenbacher <agruenba@xxxxxxxxxx> --- > [!]: Package successfully compiles and builds into binary rpms on at least one > supported primary architecture. > Koji build failed: missing dep on automake The package did actually depend on automake but shouldn't have. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/include/sys > Requires on glibc-headers required for /usr/include/sys The librichacl-devel package does not create /usr/include/sys, it only puts files there. But see below ... > [!]: Spec file is legible and written in American English. > I have no idea what "%{!?_licensedir:%global license %%doc}" does. It's from this from this commit: http://pkgs.fedoraproject.org/cgit/acl.git/commit/?id=231dae96d1ec92a18d9a53e73e080c538d5739df It defines "%license" to expand to "%doc" if %_licensedir is not defined. Seemingly that was needed in 2014; why would that have changed? > [!]: Rpmlint is run on all rpms the build produces. > Note: There are rpmlint messages (see attachment). Let's see if any of the nonsense rpmlint complains about really needs to be addressed with the updated spec file. > [!]: Package requires other packages for directories it uses. > Dep for glibc-headers missing for /usr/include/sys > Dep for pkgconfig missing for /usr/lib(64)/pkgconfig Okay, but this rule seems totally arbitrary: there are numerous packages where this is not the case, just check some of those: rpm -qf /usr/include/sys/* | sort -u rpm -qf /usr/lib64/pkgconfig/* | sort -u > [!]: SourceX is a working URL. > Please use the github tarball urls: > https://github.com/andreas-gruenbacher/richacl/archive/v1.4.tar.gz This is actually bad advice: those tarballs that github creates dynamically are git snapshots for certain tags. They do not include generated files like configure, etc. and they don't work in the context of SourceX. We could make them work by adding autoconf + automake to the dependencies and by running autoreconf, but that is not recommended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review