[Bug 1203700] Review Request: python-cligj - Click params for GeoJSON CLI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1203700



--- Comment #6 from Julien Enselme <jujens@xxxxxxxxx> ---
My example comes from the next section:
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling (sorry).

I did some digging and it appears that I was wrong. In your spec, for instance,
you use %{python2_sitelib}/%{pypi_name} to add the
/usr/lib/python2.7/site-packages/cligj directory. I always thought reading that
document
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics and
more specifically :
"
To include a single directory:
%{_datadir}/%{name}/
"

that the trailing / was compulsory when adding a directory. If it was omitted I
guessed something bad would happend. But according to
http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html (see the
'The %dir Directive' section) that the directory and its content gets correctly
added. I was also not able to find anything that would indicate that
%{python2_sitelib}/%{pypi_name} is wrong.

I still thinks that the trailing / makes the SPEC clearer (but that just me).

Sorry to have bothered you with something wrong (at least I have learned
something). Approved!

@Orion: indeed. I was typing my reply when you submitted yours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]