https://bugzilla.redhat.com/show_bug.cgi?id=1192059 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Summary should be improved to not simply repeat the package name in different order. Is a library? Is it bindings? %description should be explanded to be a useful paragraph. Can Source be downloaded from the web? Try to use a real URL. Group tags can be removed. No need to repeat License in subpackages if it is the same as the main package. Add %{?_isa} to Requires: %{name} = %{version}. Can parallel build be used? If so, add %{?_smp_flags} to make. Most likely .la files should be removed. Add 'find %{buildroot} -name \*.la -delete' or similar. Use -delete instead of -exec rm {} \; with find. Are both static libraries (*.a) and .so files needed? Use %make_install (see https://fedoraproject.org/wiki/Make_install_packaging_draft). Your package should not own %{_datadir}. What about the license: is there a license file? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review