[Bug 1215732] Review Request: pypy3 - Python 3 implementation with a Just-In-Time compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1215732



--- Comment #13 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---


(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> I think you missed those comments:
> 
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> > [!]: Package must own all directories that it creates.
> >      Note: Directories without known owners:
> >      /usr/lib/rpm/macros.d,                    → OK
> >      /usr/lib/rpm,                             → OK
> >      /usr/lib64/pypy3-2.4.0                    → should be owned
> 
> > [?]: Spec use %global instead of %define unless justified.
> >      Note: %define requiring justification: %define gcrootfinder_options
> >      --gcrootfinder=shadowstack, %define gcrootfinder_options %{nil}
> > Looks like this could be changed to %global.

I've missed them, yes, sorry.

> BuildRequires: git
> should be added for the %autosetup -S git thing to work.

OK.

> I think you can switch to building with pypy instead of python2.

Any particular reason?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]