Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: archivemail - A tool for archiving and compressing old email in mailboxes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240877 ------- Additional Comments From faucamp@xxxxxxxxxx 2007-05-23 10:31 EST ------- Mid-air collision! :-) (In reply to comment #9) > Agreed, and I was not proposing to use symlinks, I was proposing to move the > test_ script there directly. Fair enough, but I don't think its necessary to expose the unittests to all end-users; to put in bluntly: they don't do anything useful[1] > Which is why I put it in %doc in the first place (which would still be my > preference). Mine too, in this case. :-) > I was thinking I could put it in put with a note detailing how a > user could get the test script to work, namely copy it and the main script to > the same place and run. Yes, very good idea. But if you apply my proposed changes, no copying/renaming is required, only a simple Readme.tests (or whatever) saying pretty much what I said in the last paragraph of comment #10. > Given the Python shipped in Fedora, it should be > working from the get-go once the rpm is installed. Hence my use of the word > 'extraneous in Comment #2. Yes. Btw, I also removed some unecessary %doc entries (maifest, setup.py, etc) - these are required for application installation, which is RPM's job. Jochen: By the way, are you reviewing this package? If so, please assign the bug to yourself to avoid confusion (I noticed the flag when I was about to do this... :-) ) [1] except if you are debugging/developing, which normal users of the app won't be doing ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review