[Bug 1216055] Review Request: ardour4 - Digital Audio Workstation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1216055



--- Comment #7 from Nils Philippsen <nphilipp@xxxxxxxxxx> ---
Thanks for the review!

I'll make a couple of changes to fix the remaining issues:

(In reply to Brendan Jones from comment #6)
[...]
> Issues:
> =======
> - Static libraries in -static or -devel subpackage, providing -devel if
>   present.
>   Note: Package has .a files: ardour4. Illegal package name: ardour4. Does
> not
>   provide -static: ardour4.
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

- Don't install the offending static archive (which previously was dynamically
linked to a different private library), I've submitted this upstream.

> ardour4.i686: W: cross-directory-hard-link
> /usr/share/ardour4/icons/ardour_icon_512px.png
> /usr/share/icons/hicolor/512x512/apps/ardour4.png
[...]
> ardour4.i686: W: cross-directory-hard-link
> /usr/share/ardour4/icons/ardour_icon_16px.png
> /usr/share/icons/hicolor/16x16/apps/ardour4.png
[...]
> ardour4.i686: W: cross-directory-hard-link
> /usr/share/icons/hicolor/32x32/apps/ardour4.png
> /usr/share/ardour4/icons/ardour_icon_32px.png
[...]
> ardour4.i686: W: cross-directory-hard-link
> /usr/share/icons/hicolor/22x22/apps/ardour4.png
> /usr/share/ardour4/icons/ardour_icon_22px.png
[...]
> ardour4.i686: W: cross-directory-hard-link
> /usr/share/icons/hicolor/256x256/apps/ardour4.png
> /usr/share/ardour4/icons/ardour_icon_256px.png
[...]
> ardour4.i686: W: cross-directory-hard-link
> /usr/share/ardour4/icons/ardour_icon_48px.png
> /usr/share/icons/hicolor/48x48/apps/ardour4.png
[...]

- Used symlinks rather than hardlinks.

> ardour4.src: W: strange-permission Ardour-4.0.0.tar.bz2 0640L

- Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]