Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libnetfilter_log - Netfilter logging userspace library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232816 ------- Additional Comments From pertusus@xxxxxxx 2007-05-23 04:52 EST ------- (In reply to comment #3) > Good: > + Tar ball matches with upstream. > > Bad: > - You have put the BuildRequires to pkgconfig to the main package, but the > BuildRequires is required for the devel subpackage. BuildRequires are not for the main or the devel package, they are for the source package. Here indeed pkgconfig is not needed as a BuildRequires because the libnfnetlink libs is found with: AC_CHECK_LIB(nfnetlink, nfnl_subsys_open, AC_MSG_RESULT(found), AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed])) AC_CHECK_HEADER([libnfnetlink/linux_nfnetlink.h], [AC_MSG_RESULT([found])], [AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed])]) In general it is better to use pkgconfig instead, if available (it is better for multilibs, for dependencies and allows to have different subdirectories for different versions). So it would be better, in my opinion, to have something along: PKG_CHECK_MODULES([NFNETLINK],[libnfnetlink >= 0.0.16],, [ AC_CHECK_LIB(nfnetlink, nfnl_subsys_open, [NFNETLINK_LIBS=-lnfnetlink AC_MSG_RESULT(found)], AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed])) AC_CHECK_HEADER([libnfnetlink/linux_nfnetlink.h], [AC_MSG_RESULT([found])], [AC_MSG_ERROR([libnfnetlink 0.0.16 or later needed])]) ]) And in src/Makefile.am, replace -lnfnetlink with NFNETLINK_LIBS, and add NFNETLINK_CFLAGS to AM_CFLAGS This is to be tested, and for upstream, of course. Also in top level Makefile.am LINKOPTS = -lnfnetlink is unuseful Also in src/Makefile.am AM_CFLAGS = -fPIC -Wall is wrong, since -fPIC is added if needed by libtool and -Wall is not portable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review