[Bug 1208838] Re-Review Request: gdouros-alexander-fonts - A Greek typeface inspired by Alexander Wilson

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1208838

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=532816
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
            Summary|Review Request:             |Re-Review Request:
                   |gdouros-alexander-fonts - A |gdouros-alexander-fonts - A
                   |Greek typeface inspired by  |Greek typeface inspired by
                   |Alexander Wilson            |Alexander Wilson
              Flags|                            |fedora-review?



--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for F23 (x86_64)

+ rpmlint on generated rpms gave output
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
srpm Source0: 991ddddf0801d0d37b956f1de386ad6b054eda84a77aa683ef99c3e222bdd26b
upstream Source0 :
991ddddf0801d0d37b956f1de386ad6b054eda84a77aa683ef99c3e222bdd26b
srpm Source1 : 4f859cf23497d7dbdab544ba75f3eb88e3782f76738992215a9ec44e21b1ef34
upstream Source1 :
4f859cf23497d7dbdab544ba75f3eb88e3782f76738992215a9ec44e21b1ef34

+ License is "Public Domain" as per given on upstream website "Fonts and
documents in this site are not pieces of property or merchandise items; they
carry no trademark, copyright, license or other market tags; they are free for
any use". So no license text is included in font file or any text file

+ follows fonts packaging guidelines.

+ fontconfig file is present at priority 65.

+ Appdata metainfo file is present.

Suggestions:
1) cp commands should be used as "cp -p" to preserve timestamp of upstream
files being installed on the system

2) Follow
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
with following changes

%global checkout 20150430

Release:        0.2.%{checkout}%{?dist}

also add changelog that uses 5.01-0.2.20150430

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]