https://bugzilla.redhat.com/show_bug.cgi?id=1063060 --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * .spec file naming. - Please remove the version from the .spec file name, since per guidelines [1], the .spec file naming should be "%{name}.spec" * test suite - Please execute the test suite. Executing "spec lib" is probably typo. - It would be nice if you can move the %check section below %install section. This is how typical .spec file looks and it nicely follows rpmbuild's execution sequence. * -doc subpackage content - Please consider to move non-substantial stuff into -doc subpackage. I.e. %{gem_instdir}/Gemfile %{gem_instdir}/Rakefile %{gem_instdir}/spec/* %{gem_instdir}/websocket.gemspec files should be probably in -doc subpackage. * License file - Since there is no separate LICENSE file, you should 1) ask upstream to include such file. 2) move README.md into the main package, since it contains license information. * Missing period at the end of description. - Description should end by period. Please fix these issues prior I continue with the review. [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Spec_file_name -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review