https://bugzilla.redhat.com/show_bug.cgi?id=1211362 --- Comment #24 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Paulo Andrade from comment #23) > The package is approved. > > Please only fix the sequences: > > ##Build sample applications > export LDFLAGS=" " > export CFLAGS="%{optflags} -DNDEBUG" > make CFG=ReleaseDynamic -f makefile.wm5 -C WildMagic5/SampleGraphics > %{?_smp_mflags} > export LDFLAGS=" " > export CFLAGS="%{optflags} -DNDEBUG" > make CFG=ReleaseDynamic -f makefile.wm5 -C WildMagic5/SamplePhysics > %{?_smp_mflags} > export LDFLAGS=" " > export CFLAGS="%{optflags} -DNDEBUG" > make CFG=ReleaseDynamic -f makefile.wm5 -C WildMagic5/SampleImagics > %{?_smp_mflags} > export LDFLAGS=" " > export CFLAGS="%{optflags} -DNDEBUG" > make CFG=ReleaseDynamic -f makefile.wm5 -C WildMagic5/SampleMathematics > %{?_smp_mflags} > > You only need to export CFLAGS once, since all lines > export the same value. > The LDFLAGS need %__global_ldflags. It may be better to > write as %{__global_ldflags}. > > But other than the empty LDFLAGS, these are cosmetic > changes. Thank you Paulo. I'm keeping the same release number. Spec URL: https://sagitter.fedorapeople.org/wm5/wildmagic5.spec SRPM URL: https://sagitter.fedorapeople.org/wm5/wildmagic5-5.13-9.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review