https://bugzilla.redhat.com/show_bug.cgi?id=1215807 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from David King <amigadave@xxxxxxxxxxxxx> --- (In reply to Bastien Nocera from comment #3) > > - License text must use %license, not %doc > > See: > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > > > First time I hear of it. Done. Yeah, it is a new guideline that came in this development cycle. I think that you mixed up %doc and %license, as you put COPYING in %doc, and README.rst in %license. > > Optional: > > ========= > > - Fully versioned requires (from the -devel to the main package) are > > recommended > > That's already done, no? Sorry, I should have been more specific. For the -devel subpackage, rather that "Requires: %{name} = %{version}-%{release}" you should (it's optional) have "Requires: %{name}%{?_isa} = %{version}-%{release}" (note the extra "%{?_isa}". Approving, on the basis that you will fix the %license/%doc mixup. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review