https://bugzilla.redhat.com/show_bug.cgi?id=1214840 --- Comment #7 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- (In reply to Michael Scherer from comment #6) > - I am not sure the semantic of %license, but it should only include the > license > file. So CHANGES and AUTHORS should IMHO be left out. I did some research during my review and I tried to find packages with licenses, changelogs and authors in separate files. After randomly downloading ~30 srpms from koji, I found a couple that contained all three (can't remember which) and they had COPYING and AUTHORS in %license and CHANGES and README in the %doc section, which seemed reasonable, but others do not follow that reasoning. Also, many upstream projects provide author information in source headers, so this does not come up very often. Would it be an issue if the files were indeed included but separated in %doc and %license sections? > - Since the doc include jquery and there is a ongoing effort to unbundle it, > a provides should be added : > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries > > So just adding "Provides: bundled(jquery) " to the -dc subpackage should be > enough for me. <facepalm /> I looked at the sphinx html source, but it never occurred to me to consider jquery as a bundled library, will keep it in mind for the future. But why is the "Provides" necessary? Doesn't that imply that if another package requires jquery, it can use the one provided by the package? Do we want that? > - last, fedora-review complain on the requires between doc and the main > package : > > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- > statsd-doc > > That's nitpicking, but I guess the tool is right, so if you could fix that > before sending the package that would be nice. Could you please elaborate a bit how this applies here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review