https://bugzilla.redhat.com/show_bug.cgi?id=1215732 --- Comment #11 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #10) > - No %config files under /usr. > Note: %config(noreplace) /usr/lib/rpm/macros.d/macros.pypy3 > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files > > pypy3-devel.i686: W: non-etc-or-var-file-marked-as-conffile > /usr/lib/rpm/macros.d > /macros.pypy3 > > I think it's a left-over from when the file was in /etc. The user is not > supposed to modify anything in /usr. You are right. Fixing. > - Header files in -devel subpackage, if present. > Note: pypy3-libs : /usr/lib64/pypy3-2.4.0/lib_pypy/testcapi_long.h > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > > Hm, don't know what to think about this. > /usr/lib/pypy3-2.4.0/lib_pypy/_testcapimodule.c and > /usr/lib64/pypy3-2.4.0/lib_pypy/testcapi_long.h look misplaced. I think those files belong to other test files present in pypy3-libs. But I'm not sure about it. That's how it's packaged in pypy as well. > - Package contains BR: python2-devel or python3-devel > Please change BR:python-devel to BR:python2-devel. Right. Fixing. > pypy3.x86_64: W: no-manual-page-for-binary pypy3 > Upstream ships a man page, it would be nice to build it. Will check this. > And what about documentation in general? Shouldn't it be built? And this. > pypy3-libs.x86_64: E: non-standard-executable-perm > /usr/lib64/pypy3-2.4.0/lib_pypy/_tkinter/__pycache__/ > _cffi__gba38fc1bx3406ff50.pypy3-24.so 0775L > pypy3-libs.x86_64: E: non-standard-executable-perm > /usr/lib64/pypy3-2.4.0/lib_pypy/__pycache__/_cffi__ge1c56825x576c1bb2.pypy3- > 24.so 0775L > pypy3-libs.x86_64: E: non-standard-executable-perm > /usr/lib64/pypy3-2.4.0/lib_pypy/__pycache__/_cffi__ge62e22e3x1211b795.pypy3- > 24.so 0775L > pypy3-libs.x86_64: E: non-standard-executable-perm > /usr/lib64/pypy3-2.4.0/lib_pypy/__pycache__/_cffi__g93a4bf4dxace1544d.pypy3- > 24.so 0775L > Those should be 0755..., but nobody cares anyway. OK, ignoring. > pypy3-libs.x86_64: E: backup-file-in-package > /usr/lib64/pypy3-2.4.0/lib_pypy/_pypy_interact.py.orig > Hm, this looks like a bug in %autosetup. Maybe you can add '-S git' to > %autosetup. Added. > pypy3-libs.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/pypy3-2.4.0/lib_pypy/__pycache__/_cffi__ge1c56825x576c1bb2.c > pypy3-libs.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/pypy3-2.4.0/lib_pypy/__pycache__/_cffi__g93a4bf4dxace1544d.c > pypy3-libs.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/pypy3-2.4.0/lib_pypy/_ctypes_test.c > pypy3-libs.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/pypy3-2.4.0/lib_pypy/_tkinter/__pycache__/ > _cffi__gba38fc1bx3406ff50.c > pypy3-libs.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/pypy3-2.4.0/lib_pypy/__pycache__/_cffi__ge62e22e3x1211b795.c > Hm, those look strange too. It's probably not worth fighting the upstream > build system on those though, they are harmless and small. OK, ignoring. > Requires > -------- > pypy3-libs (rpmlib, GLIBC filtered): > /bin/sh > /usr/bin/env > /usr/bin/python > Hm, this seems to come from > /usr/lib/pypy3-2.4.0/lib_pypy/ctypes_config_cache/rebuild.py, > which seems to be an internal script (it contains 'import py') to be run in > the build tree. > I think it should be removed from the binary package. Done. Thanks for the feedback. I've pushed the updated spec file. I will have a look at the documentation thing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review