Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Revisor - Revisor GUI https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236642 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-22 21:36 EST ------- OK, that didn't take long. You're right, rpmlint is now silent except for: W: revisor strange-permission revisor.spec 0600 which I don't think is a blocker, but should be easily fixed by just "chmod 644 revisor.spec". It shouldn't make much difference once it gets checked into CVS anyway. There is a copy of the license in the tarball; that needs to be included in the final package as %doc. As Jef pointed out above, I see no mention of desktop-file-install; you'll need to add BR: desktop-file-utils and then something like this in %install: desktop-file-install --vendor="fedora" \ --delete-original \ --dir=%{buildroot}%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/foo.desktop The package installs fine on a handy rawhide system, shows up in the KDE menu and starts without problems. I note, though, that the menu entries do nothing for me, and if I select "Rescue Image" as the type of media to compose, I get an error dialog telling me "No media selected". I'd wager that these are not issues related to packaging and so aren't blockers, but you may know better than I. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review