[Bug 1173846] Review Request: gball - The Console Ball and Racket Game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1173846



--- Comment #8 from Mohammed Isam <mohammed_isam1984@xxxxxxxxx> ---
(In reply to Raphael Groner from comment #6)
> > Group:		Amusements/Games
> Remove this line, it's deprecated since F17.
Removed.

> > Requires(post): info
> > Requires(preun): info
> What's this for? Your info file should not harm if there's no info installed
> in the system, what I guess does not happen to often in practical usage. I
> do not know what install-info does special, maybe just copy the file in the
> right folder and reference in files section. Better remove those lines with
> Requires.
I understand install-info is just keeping things tidy, exactly as you said. I
added these according to the scriplets in
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets. If it is not
mandatory I can remove it though.

> > URL:		http://sites.google.com/site/mohammedisam2000/home/projects
> > Source0:	http://sites.google.com/site/mohammedisam2000/home/projects/%{name}-%{version}.tar.gz
> Maybe better:
> URL:		http://sites.google.com/site/mohammedisam2000/home/projects
> Source0:	%{url}/%{name}-%{version}.tar.gz
Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]