[Bug 1173846] Review Request: GBall - The Console Ball and Racket Game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1173846

Raphael Groner <projects.rg@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |projects.rg@xxxxxxxx
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1215762



--- Comment #6 from Raphael Groner <projects.rg@xxxxxxxx> ---
Review swap with py4j (bug #1215762)?

Some informal hints to the spec file:

> Group:		Amusements/Games
Remove this line, it's deprecated since F17.

> Requires(post): info
> Requires(preun): info
What's this for? Your info file should not harm if there's no info installed in
the system, what I guess does not happen to often in practical usage. I do not
know what install-info does special, maybe just copy the file in the right
folder and reference in files section. Better remove those lines with Requires.

> URL:		http://sites.google.com/site/mohammedisam2000/home/projects
> Source0:	http://sites.google.com/site/mohammedisam2000/home/projects/%{name}-%{version}.tar.gz
Maybe better:
URL:        http://sites.google.com/site/mohammedisam2000/home/projects
Source0:    %{url}/%{name}-%{version}.tar.gz

Please tell if you will fix the above issues, those are just SHOULD. Later I
can do the official fedora-review run.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]