[Bug 1211362] Review Request: wildmagic5 - Wild Magic libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1211362



--- Comment #16 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> ---
As far as I could check, the samples that create output
files, write them to the current directory. If some sample
uses a prefix to choose the name, it probably should not
be too difficult to patch.

There is a major bug, you did not quote "$@", all scripts
receive "" as argument. In the spec you should write "\$@".

I did a quick:

$ for f in `rpm -ql wildmagic5-samples |grep -v ReleaseDynamic`; do if [ ! -d
$f ]; then echo $f; $f; echo $?; fi done  

/usr/libexec/WildMagic/SampleImagics/ImViewer
did not crash, but needs an argument (i.e. "$@")

The ones that crashed:

/usr/libexec/WildMagic/SampleGraphics/Castle
/usr/libexec/WildMagic/SampleGraphics/CubeMaps
/usr/libexec/WildMagic/SampleGraphics/GlossMaps
/usr/libexec/WildMagic/SampleGraphics/MorphControllers
/usr/libexec/WildMagic/SampleGraphics/MorphFaces
/usr/libexec/WildMagic/SampleGraphics/MultipleRenderTargets
/usr/libexec/WildMagic/SampleGraphics/ProjectedTextures
/usr/libexec/WildMagic/SampleGraphics/ShadowMaps
/usr/libexec/WildMagic/SampleGraphics/SkinnedBiped
/usr/libexec/WildMagic/SampleGraphics/Skinning
/usr/libexec/WildMagic/SampleGraphics/SphereMaps
/usr/libexec/WildMagic/SampleGraphics/Terrains
/usr/libexec/WildMagic/SampleGraphics/VolumeFog
/usr/libexec/WildMagic/SampleGraphics/VolumeTextures
/usr/libexec/WildMagic/SampleImagics/GpuGaussianBlur2
/usr/libexec/WildMagic/SampleImagics/GpuGaussianBlur3
/usr/libexec/WildMagic/SampleMathematics/BSplineFitContinuous
/usr/libexec/WildMagic/SampleMathematics/DistancePointEllipseEllipsoid
/usr/libexec/WildMagic/SampleMathematics/GeodesicHeightField
/usr/libexec/WildMagic/SampleMathematics/GeodesicPaths


I stopped at

/usr/libexec/WildMagic/SampleMathematics/MeshEnvelope

because it was stuck after a few minutes.

A few tests appear to do nothing and exit too quickly, others
write output to the current directory, so need to understand
what they do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]