[Bug 1210753] Review Request: spdlog - Super fast C++ logging library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1210753



--- Comment #10 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
> spdlog-0-3.20150410git.211ce99.fc20.src.rpm

One dot too much after "git":
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


> %files
> %doc README.md
> %license LICENSE

It makes no sense to create a base package which includes only these two files.
It will never be installed by anything other than the -devel package.

Note that you can omit the %files section for the base package in order to
build no base package.

The license file can be included in the -devel package instead:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing


> %description devel
> The %{name}-devel package contains libraries and header files for
> developing applications that use %{name}.

That's a bit half-hearted. Assume it's called a "header-only library", then
"libraries and headers" is one too much.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]