https://bugzilla.redhat.com/show_bug.cgi?id=1213596 --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: ed0eb917b29027ee751215c81cac1d8c OpenID-REL1_23-ece6550.tar.gz OK - BuildRequires correct OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Changelog is messed up, should be version 4.4.0 (nonblocker) (Please fix on import) 2. Might ask upstream to include a copy of the gplv2. 3. rpmlint says: mediawiki123-openid.noarch: W: incoherent-version-in-changelog 1-1 ['4.4.0-1.el7', '4.4.0-1'] (would be fixed with fixing the changelog) mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/SpecialOpenIDLogin.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/SpecialOpenIDXRDS.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/OpenIDProvider.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/SpecialOpenIDConvert.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/SpecialOpenID.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/SpecialOpenIDIdentifier.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/SpecialOpenIDServer.body.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/OpenID.php mediawiki123-openid.noarch: E: incorrect-fsf-address /usr/share/mediawiki123/extensions/OpenID/optionToTable.php (You already mentioned you talked to upstream about this one) 2 packages and 0 specfiles checked; 9 errors, 1 warnings. 4. Shouldn't there be a Requires here on php-pear-Auth-OpenID ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review