https://bugzilla.redhat.com/show_bug.cgi?id=1213595 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 9df8930cab9db47dbc6173c45afb5945 intersection-REL1_23-1a507c8.tar.gz OK - BuildRequires correct OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Might ask upstream to include a copy of the GPLv2 (nonblocker) 2. Your comment in changelog says "1.23", but this is 1.7.0. (nonblocker) (please fix on import) 3. rpmlint says: mediawiki123-intersection.noarch: W: spelling-error %description -l en_US bulleted -> billeted, bullet ed, bullet-ed mediawiki123-intersection.noarch: W: no-documentation mediawiki123-intersection.src: W: spelling-error %description -l en_US bulleted -> billeted, bullet ed, bullet-ed 2 packages and 0 specfiles checked; 0 errors, 3 warnings. All can be ignored. I don't see any blockers here, so this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review