https://bugzilla.redhat.com/show_bug.cgi?id=1210941 Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.ploumistos@xxxxxxxxx --- Comment #1 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- Hello, This is an informal review. I've had some years of experience with Python, but everything I ever wrote was very narrow-scope and vastly different than this, so please excuse (but do point out) any blunders. On to the review. I had checked the upstream package before getting on to running fedora-review, so it struck me as odd to see a no-manual-page-for-binary warning from rpmlint, as there exists an isrcsubmit.1.rst file. However, the resulting rpm does not contain "isrcsubmit.1". I have never used sphinx to produce documentation, but perhaps the problem stems from the .rst file extension, as all scripts that reference the file do so without its extension. Have you tried adding a %{_mandir}/man1/%{name}.1* in your %files section? Also, the source file is not groff formatted and that could be part of the problem. I think it's worth exploring. I had also noticed that there is a test file included in the upstream package (which probably should be considered CC0 instead of GPLv3+ if it were to be included) and I was wondering why you hadn't placed it in a %check section in your spec file, but I ran the tests myself and a couple of them required to have a CD inserted, while the rest that made use of the included samples failed with the highly enlightening "False is not true" message. Do you have any idea why that happens? I believe you could get rid of the "rm -rf $RPM_BUILD_ROOT" in your %install section, unless you want the package to build against rhel 5. Other than that, your file looks clean, well-structured and up to the latest specs. As for the python-keyring requirement, since we do not have something like optional dependencies, I guess I would put it just like you have. Every other item on fedora-review's checklist seems in order and according to the Python Packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review