https://bugzilla.redhat.com/show_bug.cgi?id=1199296 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9497308 $ rpmlint laszip laszip-devel laszip.i686: W: spelling-error Summary(en_US) compant -> company, compact, com pant laszip.i686: W: spelling-error %description -l en_US rapidlasso -> rapid lasso, rapid-lasso, rapidness laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 vtable for __cxxabiv1::__class_type_info laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 vtable for __cxxabiv1::__si_class_type_info laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __cxa_pure_virtual laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 typeinfo for int laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __gxx_personality_v0 laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_ostream<char, std::char_traits<char> >::seekp(std::fpos<__mbstate_t>) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_ostream<char, std::char_traits<char> >::tellp() laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 operator delete(void*) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __cxa_end_catch laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __cxa_allocate_exception laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_istream<char, std::char_traits<char> >::seekg(long long, std::_Ios_Seekdir) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_istream<char, std::char_traits<char> >::tellg() laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_istream<char, std::char_traits<char> >::get() laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 operator new(unsigned int) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_ostream<char, std::char_traits<char> >::put(char) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_istream<char, std::char_traits<char> >::seekg(std::fpos<__mbstate_t>) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 operator delete[](void*) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 operator new[](unsigned int) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __cxa_begin_catch laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __cxa_rethrow laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 __cxa_throw laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_istream<char, std::char_traits<char> >::read(char*, int) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_ostream<char, std::char_traits<char> >::write(char const*, int) laszip.i686: W: undefined-non-weak-symbol /usr/lib/liblaszip.so.6.0.0 std::basic_ostream<char, std::char_traits<char> >::seekp(long long, std::_Ios_Seekdir) laszip.i686: E: incorrect-fsf-address /usr/share/licenses/laszip/COPYING laszip.i686: W: devel-file-in-non-devel-package /usr/lib/liblaszip.so laszip.i686: W: no-manual-page-for-binary laszippertest laszip.i686: W: install-file-in-docs /usr/share/doc/laszip/INSTALL laszip-devel.i686: W: no-documentation 2 packages and 0 specfiles checked; 1 errors, 30 warnings. per the warnings, several of these need to be addressed: 1. SHOULD fix liblaszip undefined symbols, probably just missing -lstdc++ linkage, I can help come up with a patch for this (not treating as review blocker, but will need to be addressed if you expect to build anything using this). 2. MUST move %{_libdir}/liblaszip.so symlink to -devel subpkg 3. SHOULD omit INSTALL from %doc naming: ok sources: ok 1693724d8284dc04f04eb0b86f7de2cc laszip-src-2.2.0.tar.gz 4. license: NOT ok source files and COPYING refer to LGPLv2, so MUST use License: LGPLv2 5. MUST fix %{_includedir}/laszip/ dir being unowned, I'd suggest replacing %{_includedir}/laszip/*.hpp with %{_includedir}/laszip/ 6. SHOULD omit liblaszip.a static library, I'd suggest using configure flag: %configure --disable-static 7. -devel subpkg MUST depend on main pkg (using %_isa macro) Requires: %{name}%{?_isa} = %{version}-%{release} 8. SHOULD omit deprecated Group: tags and %clean section 9. SHOULD drop not needed dependency: BuildRequires: cmake macros: ok scriptlets: ok -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review