https://bugzilla.redhat.com/show_bug.cgi?id=1182261 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #46 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Few changes I will suggest which is common practice 1) static library files generally removed in %install section so no need to remove them using exclude in %files We pass the --disable-static to %configure, this will not generate .a file Then we need to add below %make_install following find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' 2) you should write all %post %postun scriptlets before %files section 3) BuildRequires: python-sphinx-latex is not required as that package got removed from repository now. Rest looks fine. Submit new srpm and spec by increasing release to -4 and adding changelog. I will approve this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review