[Bug 1212103] Review Request: perl-Text-Template-Simple - Simple text template engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1212103

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Text-Template-Simple-0.86-1.fc23.noarch.rpm | sort |
uniq -c
      1 perl(:MODULE_COMPAT_5.20.2)
      1 perl(Carp)
      1 perl(Data::Dumper) >= 2.101
      1 perl(Devel::Size) >= 0.77
      1 perl(Digest::MD5)
      1 perl(Exporter)
      1 perl(FIle::stat)
      1 perl(Fcntl) >= 1.03
      1 perl(File::Find)
      1 perl(File::Spec)
      1 perl(File::Spec) >= 0.6
      1 perl(IO::File)
      1 perl(IO::Handle)
      1 perl(Perl::Tidy)
      1 perl(Safe) >= 2.06
      1 perl(Symbol)
      1 perl(Text::Table) >= 1.107
      1 perl(Text::Template::Simple::Cache)
      1 perl(Text::Template::Simple::Cache::ID)
      1 perl(Text::Template::Simple::Caller)
      1 perl(Text::Template::Simple::Compiler)
      1 perl(Text::Template::Simple::Compiler::Safe)
      1 perl(Text::Template::Simple::Constants)
      1 perl(Text::Template::Simple::Dummy)
      1 perl(Text::Template::Simple::IO)
      1 perl(Text::Template::Simple::Tokenizer)
      1 perl(Text::Template::Simple::Util)
      1 perl(base)
      1 perl(constant)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are almost ok.

FIX: typo in Requires perl(FIle::stat) should be perl(File::stat)
TODO: Filter unversioned perl(File::Spec)

$ rpm -qp --provides perl-Text-Template-Simple-0.86-1.fc23.noarch.rpm | sort |
uniq -c
      1 perl(Text::Template::Simple) = 0.86
      1 perl(Text::Template::Simple::Base::Compiler) = 0.86
      1 perl(Text::Template::Simple::Base::Examine) = 0.86
      1 perl(Text::Template::Simple::Base::Include) = 0.86
      1 perl(Text::Template::Simple::Base::Parser) = 0.86
      1 perl(Text::Template::Simple::Cache) = 0.86
      1 perl(Text::Template::Simple::Cache::ID) = 0.86
      1 perl(Text::Template::Simple::Caller) = 0.86
      1 perl(Text::Template::Simple::Compiler) = 0.86
      1 perl(Text::Template::Simple::Compiler::Safe) = 0.86
      1 perl(Text::Template::Simple::Constants) = 0.86
      1 perl(Text::Template::Simple::Dummy) = 0.86
      1 perl(Text::Template::Simple::IO) = 0.86
      1 perl(Text::Template::Simple::Tokenizer) = 0.86
      1 perl(Text::Template::Simple::Util) = 0.86
      1 perl-Text-Template-Simple = 0.86-1.fc23
Binary provides are Ok.

$ rpmlint ./perl-Text-Template-Simple*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' item

Otherwise package is good.
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]