https://bugzilla.redhat.com/show_bug.cgi?id=1161035 Zuzana Svetlikova <zsvetlik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zsvetlik@xxxxxxxxxx --- Comment #2 from Zuzana Svetlikova <zsvetlik@xxxxxxxxxx> --- Some comments: - not latest version - please try to use npm registry in sources, I am having difficulties with packages with github source (http://fedoraproject.org/wiki/User:Patches/PackagingDrafts/NodeJS#Using_tarballs_from_the_npm_registry) - put BuildRequires for devDependencies in conditional, please - missing nodejs_symlink_macros in both %install and %check - LICENSE should be in %license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review