https://bugzilla.redhat.com/show_bug.cgi?id=1210754 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- json.spec.old 2015-04-14 13:37:12.000000000 +0200 +++ json.spec 2015-04-14 14:31:50.000000000 +0200 @@ -11,7 +11,7 @@ Group: Development/Libraries License: MIT ## Not installed -# src/json.hpp: Boost Software License, Version 1.0 +# test/catch.hpp: Boost Software License, Version 1.0 URL: https://github.com/%{user}/%{name}/ Source0: https://github.com/%{user}/%{name}/tarball/%{gittag}/%{user}-%{name}-%{shorttag}.tar.gz @@ -28,7 +28,6 @@ Group: Development/Libraries Provides: %{name}-static = %{version}-%{release} Requires: %{name} = %{version}-%{release} -Requires: pkgconfig Requires: libstdc++-devel %description devel @@ -43,7 +42,7 @@ %check make cppcheck -make json_unit +make && ./json_unit %install mkdir -p %{buildroot}%{_includedir} > TODO: The file is test/catch.hpp, not src/json.hpp. -# src/json.hpp: Boost Software License, Version 1.0 +# test/catch.hpp: Boost Software License, Version 1.0 Ok. > TODO: This compiles the test, but does not execute it. You have to execute > the resulting ./json_unit. -make json_unit +make && ./json_unit Ok. > FIX: The package does not build in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9476433) It passes, but only but only because of a bug in the rpmbuild. The `make' fails, so the ./json_unit is not executed, the return value of this command list is non-zero, but rpmbuild interprets it as a success. You can verify it with `false && false'. This should stop the rpmbuild, but it passes. I will pass this review because if you do not want to fix the Catch.hpp, you will disable the test and guidelines does not require running tests. But please note that once rpmbuild get fixed, your contemporary spec file will fail too. Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9476781). Ok. > TODO: You should unbundle the catch.hpp. It could be fixed in the upstream <https://github.com/philsquared/Catch>. Not addressed. Ok. $ rpmlint json.spec ../SRPMS/json-0-2.20150410git.d7d0509.fc23.src.rpm ../RPMS/x86_64/json-* json.src: W: name-repeated-in-summary C JSON json.src: W: spelling-error %description -l en_US nlohmann -> Eichmann json.x86_64: W: name-repeated-in-summary C JSON json.x86_64: W: spelling-error %description -l en_US nlohmann -> Eichmann json.x86_64: E: no-binary 3 packages and 1 specfiles checked; 1 errors, 4 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/x86_64/json-0-2.20150410git.d7d0509.fc23.x86_64.rpm | sort -f | uniq -c 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --requires -p ../RPMS/x86_64/json-devel-0-2.20150410git.d7d0509.fc23.x86_64.rpm | sort -f | uniq -c 1 json = 0-2.20150410git.d7d0509.fc23 1 libstdc++-devel 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/x86_64/json-* Binary dependencies resolvable. Ok. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review