https://bugzilla.redhat.com/show_bug.cgi?id=1210754 --- Comment #7 from Daniel Kopeček <dkopecek@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #5) >> TODO: Document Boost license (test/catch.hpp) in a spec file comment. > +## Not installed > +# src/json.hpp: Boost Software License, Version 1.0 > TODO: The file is test/catch.hpp, not src/json.hpp. Fixed. > > TODO: Run the tests (make && ./json_unit). > %check > make cppcheck > +make json_unit > TODO: This compiles the test, but does not execute it. You have to execute > the resulting ./json_unit. Yeah, I just realized it too. Spec file is now updated with the "make && ./json_unit" > FIX: The package does not build in F23 > (http://koji.fedoraproject.org/koji/taskinfo?taskID=9476433): Should be ok now: http://koji.fedoraproject.org/koji/taskinfo?taskID=9476566 > TODO: You should unbundle the catch.hpp. It could be fixed in the upstream > <https://github.com/philsquared/Catch>. Not fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review