https://bugzilla.redhat.com/show_bug.cgi?id=1210754 --- Comment #3 from Daniel Kopeček <dkopecek@xxxxxxxxxx> --- Updated the spec file and srpm. URLs are the same. (In reply to Petr Pisar from comment #1) > TODO: Please note there has already been a `json' package in Fedora (bug > #495801). The name of this package is not very inventive and it can lead to > confusions. Please consider more designating name. Not fixed. > TODO: Use the github syntax for computing shorttag recommended by > guidelines. The recommended code does not depend on coreutils. Fixed. > TODO: Document Boost license (test/catch.hpp) in a spec file comment. Fixed. > TODO: I recommend not creating non-upstream pkg-config module. Such > distribution-specific extensions give to developers an opportunity to write > non-portable code. Fixed. > TODO: The src/json.hpp is generated file. Regenerate it from > src/json.hpp.re2c. Not fixed. > TODO: Run the tests (make && ./json_unit). Fixed. > TODO: Normalize spaces in the spec file. Fixed. > FIX: Disable generating debuginfo package (%global debug_package %{nil}). Fixed. > FIX: Run-require `libstdc++-devel' by json-devel because Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review